This repository was archived by the owner on Feb 23, 2023. It is now read-only.
make reflection analysis cover kotlin coroutines usage#1432
Closed
czp3009 wants to merge 3 commits intospring-attic:mainfrom
Closed
make reflection analysis cover kotlin coroutines usage#1432czp3009 wants to merge 3 commits intospring-attic:mainfrom
czp3009 wants to merge 3 commits intospring-attic:mainfrom
Conversation
|
@czp3009 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@czp3009 Thank you for signing the Contributor License Agreement! |
Contributor
|
Interesting proposal that could maybe fix #769 more easily than originally expected, could you please update webflux-kotlin to remove those manual hints and see if that works? Also could you please update the PR to perform this type inferience only when this type is a |
sdeleuze
added
type: compatibility
Contributor
|
Merged with additional refinements via #769, thanks a lot for this great PR! |
sdeleuze
removed
the
status: waiting-for-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a controller method is kotlin coroutine suspend fun, it's return type will be
Continuation<? super Bar>In this situation,
returnType.getActualTypeArguments()[0]will be? super Bar, it's a WildcardType, and lower bounds is the exact return typeBar.So we need to dig out the type
Barfrom the original wrapped Continuation type.If just skip the WildcardType, suspend fun will be considered as a method which return Object.
Adding a lot of @typehint is very bad for migrating old projects to spring native, I want to analyze directly in spring aot to get the actual return value of suspend fun.